Skip to content

feat(sdk): implement message wait time estimation#2127

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-wait-time
Feb 3, 2022
Merged

feat(sdk): implement message wait time estimation#2127
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-wait-time

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Feb 3, 2022

Description
Implements the SDK's estimateMessageWaitTime function + tests.

Metadata

  • Fixes ENG-1804
  • Fixes ENG-1803

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: cb81c4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2127 (a11f8da) into develop (fc0b313) will decrease coverage by 9.87%.
The diff coverage is 91.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2127      +/-   ##
===========================================
- Coverage    82.83%   72.96%   -9.88%     
===========================================
  Files           48       85      +37     
  Lines         1445     2918    +1473     
  Branches       216      496     +280     
===========================================
+ Hits          1197     2129     +932     
- Misses         248      789     +541
Flag Coverage Δ
batch-submitter 62.63% <ø> (?)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <ø> (?)
message-relayer 70.86% <ø> (?)
sdk 70.86% <91.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/cross-chain-messenger.ts 71.55% <90.62%> (ø)
packages/sdk/src/utils/chain-constants.ts 100.00% <100.00%> (ø)
packages/sdk/src/utils/coercion.ts 90.62% <100.00%> (ø)
packages/sdk/src/utils/index.ts 100.00% <100.00%> (ø)
packages/message-relayer/hardhat.config.ts 100.00% <0.00%> (ø)
packages/sdk/src/utils/message-encoding.ts 100.00% <0.00%> (ø)
packages/sdk/src/adapters/dai-bridge.ts 35.71% <0.00%> (ø)
packages/sdk/src/utils/misc-utils.ts 100.00% <0.00%> (ø)
packages/batch-submitter/src/index.ts 100.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0b313...a11f8da. Read the comment docs.

@smartcontracts smartcontracts merged commit adce9c2 into develop Feb 3, 2022
@smartcontracts smartcontracts deleted the sc/sdk-wait-time branch February 3, 2022 20:40
theochap pushed a commit that referenced this pull request Dec 10, 2025
@emhane
chore(supervisor/storage): Add note about local unsafe block to `Deri…
9ef220b 
…vationStorageReader::derived_to_source` (#2127)

Add note to docs for `DerivationStorageReader::derived_to_source` about
L1 source block of local unsafe block, possibly not yet being written to
db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SmitV SmitV SmitV approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartcontracts @codecov-commenter @SmitV